Making id and name length configrable so that id and name can be set larger than 128 and 256 respectively

[jakhani]

Pull Request type

• Bugfix
• Feature
• Refactoring (no functional changes, no api changes)
• Build related changes (Please run ./gradlew build --write-locks to refresh dependencies)
• Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Describe the new behavior from this PR, and why it's needed

Maestro's ID and name length limits (128 and 256 respectively) are currently compile-time constants. This PR makes them configurable at runtime via application config, with defaults that preserve existing behavior for all deployments that do not explicitly override them.

Motivation: Some workflows migrated from Airflow have DAG IDs up to 226 characters and task IDs up to 249 characters. The database already supports larger sizes; only the application validation layer needs updating.

No default behavior change: If maestro.maestro-id-name-validation is not set in config, limits default to exactly the same values as before (128 for IDs, 256 for names). Existing deployments are unaffected.

Changes in this PR

maestro-common

• Added MaestroIdNameValidationLimits interface (in com.netflix.maestro.utils) exposing getIdLengthLimit() and getNameLengthLimit(). Includes a DEFAULTS constant (backed by Constants) used as a fallback when the interface is not injected (e.g. unit tests without Spring).
• Added MaestroNameSizeConstraint — a null-safe, length-only annotation that replaces @Size(max = Constants.NAME_LENGTH_LIMIT) on optional name fields (Workflow.name, AbstractStep.name) where the limit must be configurable at runtime.
• Updated MaestroIdConstraint, MaestroNameConstraint, MaestroReferenceIdConstraint, and MaestroNameSizeConstraint to inject MaestroIdNameValidationLimits via @Inject (same pattern as AlertingValidator in PropertiesConstraint). Each validator falls back to MaestroIdNameValidationLimits.DEFAULTS when not injected.

maestro-server

• Added MaestroIdNameValidationProperties — Spring @ConfigurationProperties bound under maestro.maestro-id-name-validation.*, implementing MaestroIdNameValidationLimits. Field-level defaults match Constants, so any unconfigured limit automatically retains its original value independently (e.g. configuring only id-length-limit leaves name-length-limit at 256).
• Added MaestroIdNameValidationConfiguration — exposes MaestroIdNameValidationProperties as a MaestroIdNameValidationLimits Spring @Bean so validators can inject it.
• Wired MaestroIdNameValidationProperties into MaestroProperties.

Tests

• Added MaestroIdNameValidationLimitsTest covering each constraint (MaestroIdConstraint, MaestroNameConstraint, MaestroReferenceIdConstraint, MaestroNameSizeConstraint) with a custom ConstraintValidatorFactory that injects arbitrary MaestroIdNameValidationLimits via reflection on @Inject fields — no Spring context required.
• Updated MaestroIdConstraintTest, MaestroNameConstraintTest, MaestroReferenceIdConstraintTest to reference Constants directly instead of the old static holder.

Testing done:
Unit tests are passing.
Verified in local Maestro server by setting id and name limit to 200 and creating a dag with smaller and larger length than that.

┌───────────────────────────┬──────────────┬─────────────────────────────────────────────────────────────────┐
│           Test            │    Input     │                             Result                              │
├───────────────────────────┼──────────────┼─────────────────────────────────────────────────────────────────┤
│ Dag ID = 128 chars        │ at old limit │ ✅ PASS                                                         │
├───────────────────────────┼──────────────┼─────────────────────────────────────────────────────────────────┤
│ Dag ID = 200 chars        │ at new limit │ ✅ PASS                                                         │
├───────────────────────────┼──────────────┼─────────────────────────────────────────────────────────────────┤
│ Dag ID = 201 chars        │ over limit   │ ✅ FAIL with "id length limit 200 - rejected length is [201]"   │
├───────────────────────────┼──────────────┼─────────────────────────────────────────────────────────────────┤
│ Dag name = 200 chars      │ at new limit │ ✅ PASS                                                         │
├───────────────────────────┼──────────────┼─────────────────────────────────────────────────────────────────┤
│ Dag name = 201 chars      │ over limit   │ ✅ FAIL with "name length limit 200 - rejected length is [201]" │
├───────────────────────────┼──────────────┼─────────────────────────────────────────────────────────────────┤
│ Step ID = 200 chars       │ at new limit │ ✅ PASS                                                         │
├───────────────────────────┼──────────────┼─────────────────────────────────────────────────────────────────┤
│ Step ID = 201 chars       │ over limit   │ ✅ FAIL with "id length limit 200 - rejected length is [201]"   │
└───────────────────────────┴──────────────┴─────────────────────────────────────────────────────────────────┘

Note: The limit is fully configurable via maestro.maestro-id-name-validation.id-length-limit and maestro.maestro-id-name-validation.name-length-limit in application.yml, with no code changes required.

[akashdw]

May be MaestroNameIdValidationLimits or MaestroNameIdValidationConfigs

[praneethy91]

LGTM, thanks for making the changes!

[rdeepak2002]

Latest changes lgtm and are well-tested, thanks!