Fix getDefaultSinkParams not returning additionalParams#750
Merged
crioux-stripe merged 3 commits intoNetflix:masterfrom Feb 20, 2025
Merged
Fix getDefaultSinkParams not returning additionalParams#750crioux-stripe merged 3 commits intoNetflix:masterfrom
crioux-stripe merged 3 commits intoNetflix:masterfrom
Conversation
crioux-stripe
approved these changes
Feb 18, 2025
tcai-stripe
requested review from
Andyz26,
calvin681,
dtrager02,
fdc-ntflx and
hmitnflx
as code owners
crioux-stripe
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fix the bug introduced in #748 where getDefaultSinkParams didn't update with additional params
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests