Skip to content

Update worker failure metric #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hellolittlej merged 2 commits into from
Sep 25, 2025
Merged

Update worker failure metric #792

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77b68e0
Update worker failure metric
Sep 24, 2025
7f67f67
Merge branch 'master' into update-metric
hellolittlej Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions mantis-runtime-executor/src/main/java/io/mantisrx/server/worker/RunningWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@

import static io.mantisrx.server.core.utils.StatusConstants.STATUS_MESSAGE_FORMAT;

import com.netflix.spectator.api.Tag;
import io.mantisrx.common.metrics.Metrics;
import io.mantisrx.common.metrics.MetricsRegistry;
import io.mantisrx.common.metrics.spectator.SpectatorRegistryFactory;
import io.mantisrx.runtime.Context;
import io.mantisrx.runtime.Job;
import io.mantisrx.runtime.MantisJobState;
Expand Down Expand Up @@ -160,14 +158,13 @@ public void signalFailed(Throwable t) {
logger.error("Worker failure detected, shutting down job: {}", jobId, t);
// Send failure metrics when data emission failed
if (t instanceof OnErrorThrowable) {
Metrics jobFailureMetrics = new Metrics.Builder()
.id(workerMonitorMetricId, Tag.of("jobId", this.jobId),
Tag.of("workerIndex", String.valueOf(this.workerIndex)),
Tag.of("stageNum", String.valueOf(this.stageNum)))
.addCounter(workerFailureMetricName)
.build();

MetricsRegistry.getInstance().registerAndGet(jobFailureMetrics).getCounter(workerFailureMetricName).increment();
SpectatorRegistryFactory.getRegistry()
.counter("runningWorker_failure",
"jobId", jobId,
"workerIndex", String.valueOf(this.workerIndex),
"stageNum", String.valueOf(this.stageNum)
)
.increment();
}

jobStatus.onNext(new Status(jobId, stageNum, workerIndex, workerNum,
Expand Down
Loading