Skip to content

Fix inconsitent return type for the delete jobcluster#810

Merged
hellolittlej merged 1 commit intomasterfrom
fix-delete-api-type
Nov 21, 2025
Merged

Fix inconsitent return type for the delete jobcluster#810
hellolittlej merged 1 commit intomasterfrom
fix-delete-api-type

Conversation

@hellolittlej
Copy link
Copy Markdown
Collaborator

@hellolittlej hellolittlej commented Nov 21, 2025

Context

  • current delete endpoint will return plain string when user is absent and json when error raises.
  • we should keep the endpoint behavior consistent to always return application/json

Explain context and other details for this pull request.

Checklist

  • ./gradlew build compiles code correctly
  • Added new tests where applicable
  • ./gradlew test passes all tests
  • Extended README or added javadocs where applicable
    @Andyz26

@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 21, 2025

Test Results

661 tests  ±0   650 ✅ ±0   9m 7s ⏱️ +3s
152 suites ±0    11 💤 ±0 
152 files   ±0     0 ❌ ±0 

Results for commit e618254. ± Comparison against base commit 4ef1ba1.

♻️ This comment has been updated with latest results.

@hellolittlej hellolittlej had a problem deploying to Integrate Pull Request November 21, 2025 18:49 — with GitHub Actions Failure
@hellolittlej hellolittlej merged commit 4862c9b into master Nov 21, 2025
6 of 7 checks passed
@hellolittlej hellolittlej deleted the fix-delete-api-type branch November 21, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants