Skip to content

add more logging for mesos scheduler driver init #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickmahilani merged 1 commit into from
Jan 16, 2021
Merged

add more logging for mesos scheduler driver init #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ntrol-plane-server/src/main/java/io/mantisrx/server/master/mesos/MesosDriverSupplier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ public MesosDriverSupplier(final MasterConfiguration masterConfig,
@Override
public MesosSchedulerDriver get() {
if (addVMLeaseAction == null) {
logger.warn("addVMLeaseAction is null, attempt to get Mesos Driver before MesosDriverSupplier init");
throw new IllegalStateException("addVMLeaseAction must be set before creating MesosSchedulerDriver");
}

Expand All @@ -77,7 +78,8 @@ public MesosSchedulerDriver get() {
logger.info("initializing mesos scheduler driver");
final MesosSchedulerDriver mesosDriver =
new MesosSchedulerDriver(mesosSchedulerCallbackHandler, framework, masterConfig.getMasterLocation());
mesosDriverRef.compareAndSet(null, mesosDriver);
boolean result = mesosDriverRef.compareAndSet(null, mesosDriver);
logger.info("initialized mesos scheduler driver {}", result);
}

return mesosDriverRef.get();
Expand Down
6 changes: 5 additions & 1 deletion ...r/src/main/java/io/mantisrx/server/master/mesos/VirtualMachineMasterServiceMesosImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,9 @@ public void killTask(final WorkerId workerId) {
}
} catch (RuntimeException e) {
// IllegalStateException from no mesosDriver's addVMLeaseAction or NPE from mesosDriver.get() being null.
if (mesosDriver.get() == null) {
logger.warn("mesosDriver supplier returned null mesosDriver");
}
logger.error("Unexpected to see Mesos driver not initialized", e);
System.exit(2);
}
Expand All @@ -424,7 +427,8 @@ public void call() {
executor.execute(() -> {
try {
logger.info("invoking the Mesos driver run");
mesosDriver.get().run();
Protos.Status status = mesosDriver.get().run();
logger.info("MesosSchedulerDriver run status {}", status);
} catch (Exception e) {
logger.error("Failed to register Mantis Framework with Mesos", e);
System.exit(2);
Expand Down