Skip to content

Conversation

@obgibson
Copy link
Collaborator

Requirements for a pull request

  • Unit tests related to the change have been updated
  • Documentation related to the change has been updated

Description of the Change

Changes an a element to a Link component for the trigger link so that the link respects the basename set on Router. This fixes a bug where the REACT_APP_BASE_PATH env variable was set but the trigger link did not include it.

Alternate Designs

-

Possible Drawbacks

-

Verification Process

  • Set REACT_APP_BASE_PATH
  • Find a run that was triggered by another run
  • Click on the trigger link at the top of the page and ensure the REACT_APP_BASE_PATH value is at the start of the URL

Release Notes

Change a to Link for trigger link

@obgibson obgibson requested a review from oavdeev February 24, 2024 05:26
@obgibson obgibson merged commit 7731f98 into master Feb 27, 2024
@obgibson obgibson deleted the bug/trigger-link-basename branch February 27, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants