Skip to content

Conversation

@obgibson
Copy link
Collaborator

Requirements for a pull request

  • Unit tests related to the change have been updated
  • Documentation related to the change has been updated

Description of the Change

I don’t know if this is just me but if you have a long list of tasks and you are in the timeline view and then select a task to view in the task view, while it remembers what task you selected it presents the list of task back at the top (so if you selected something after scrolling, you have to scroll again to get to it. It doesn’t do this when you are already in task view

This change scrolls the list so that the active task is visible in the task list.

Screen.Recording.2024-04-30.at.7.57.14.AM.mov

Alternate Designs

I considered capturing the index of the clicked task when it was clicked in the timeline view, storing that value somewhere, and using that value to scroll to the correct place in the task list. The approach that I used was simpler.

Possible Drawbacks

The task won't be in the same position as when it was clicked.

Verification Process

  • Find a run with lots of tasks
  • Click on a task in the timeline view
  • Verify that the task is visible and highlighted in the task list

Release Notes

Scroll to task position when task is clicked in the timeline view

@obgibson obgibson requested a review from romain-intel April 30, 2024 14:03
@obgibson obgibson merged commit b2464ab into master May 2, 2024
@obgibson obgibson deleted the feature/timeline-task-scroll branch May 2, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants