drop support for python 3.5 #2418
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR drops Python 3.5 support by removing vendored 3.5 packages and bumping the minimum supported version to 3.6.
- Removed references and files for the vendored Python 3.5 packages.
- Updated version checks and debug/error messages to require Python 3.6+.
- Cleared out all code and licenses under
metaflow/_vendor/v3_5.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| metaflow/vendor.py | Removed vendor_v3_5.txt from the vendored files list |
| metaflow/extension_support/init.py | Bumped extension support checks and messages to require Python 3.6+ |
| metaflow/cmd/develop/stubs.py | Updated stub-building logic to Python 3.6+ and error message |
| metaflow/_vendor/vendor_v3_5.txt | Cleared outdated vendored dependency entries |
| metaflow/_vendor/v3_5/zipp.py | Removed vendored zipp implementation for Python 3.5 |
| metaflow/_vendor/v3_5/zipp.LICENSE | Removed zipp license file |
| metaflow/_vendor/v3_5/importlib_metadata/_compat.py | Removed importlib_metadata compatibility code for Python 3.5 |
| metaflow/_vendor/v3_5/importlib_metadata.LICENSE | Removed importlib_metadata license file |
| metaflow/_vendor/v3_5/init.py | Removed empty module stub |
Comments suppressed due to low confidence (2)
metaflow/_vendor/v3_5/init.py:1
- The entire
v3_5vendored directory is now unused; consider deletingmetaflow/_vendor/v3_5/and its files to remove dead code.
# Empty file
metaflow/cmd/develop/stubs.py:49
- [nitpick] The phrasing of version requirements varies (
3.6+ is neededvs.3.6 minimum required); consider standardizing to a single clear format, e.g.,Python 3.6+ is required.
(3.6 minimum required)
|
|
||
| def get_modules(extension_point): | ||
| modules_to_load = [] | ||
| if not _mfext_supported: |
There was a problem hiding this comment.
This can completely go away. I thought I actually did this in a PR somewhere.
There was a problem hiding this comment.
how so? it will fail mysteriuosly if this block is removed
There was a problem hiding this comment.
_mfext_supported was only false for 3.4 or below so now that that is never true, anything mentioning mfext_supported can go away. It can now be assumed to be true.
There was a problem hiding this comment.
now it's false for less than 3.6 so it will throw a nice error if someone tries to use 3.5
There was a problem hiding this comment.
But it's not supported on 3.5. That's my point. The whole metaflow won't be on 3.5 anymore.
|
dropping this in lieu of #2424 |
No description provided.