Fixed Typos and Syntax Errors in Cards UI#3169
Conversation
Greptile SummaryThis PR fixes a collection of typos, syntax errors, and a logic bug across the Metaflow Cards UI: an invalid 7-digit hex color ( Confidence Score: 5/5This PR is safe to merge — all changes are targeted, well-scoped fixes with no functional regressions. All changes are straightforward corrections to typos, syntax errors, and one clear variable-reference bug. The source changes are reflected in the regenerated bundle artifacts. No new logic is introduced. No files require special attention. Important Files Changed
Reviews (4): Last reviewed commit: "build: rebuild card UI components" | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
This PR addresses small correctness and polish issues across the Metaflow Cards UI demo and components, primarily fixing typos and minor syntax errors.
Changes:
- Fixes a
convertPixelsToRemdocument reference bug by using the passeddocparameter. - Corrects invalid CSS/TS constants and minor Svelte/HTML syntax issues.
- Updates demo card JSON copy/typos (including a DAG subtitle and an embedded stacktrace message).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| metaflow/plugins/cards/ui/src/utils.ts | Uses the provided doc instead of the global document when reading the root font size. |
| metaflow/plugins/cards/ui/src/constants.ts | Fixes an invalid hex color for dkSecondary. |
| metaflow/plugins/cards/ui/src/components/text.svelte | Fixes a malformed HTML comment in the component header. |
| metaflow/plugins/cards/ui/src/components/main.svelte | Fixes missing CSS semicolon for min-width. |
| metaflow/plugins/cards/ui/src/app.css | Removes duplicated "Roboto" entry from the font-family list. |
| metaflow/plugins/cards/ui/demo/card-example.json | Fixes typos in demo text/stacktrace content and adjusts a JSON-in-string example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3169 +/- ##
=========================================
Coverage ? 27.33%
=========================================
Files ? 376
Lines ? 51827
Branches ? 9166
=========================================
Hits ? 14168
Misses ? 36753
Partials ? 906 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @agsaru ! Can you rebuild the card components as well as part of this PR? I believe its an |
|
@talsperre done. |
PR Type
Summary
This PR fixes multiple typos and syntax errors across the Metaflow Cards UI codebase.
1. card-example.json
{[{to[{"acyclical"→"acyclic""Hellow There"→"Hello There"2. app.css
"Roboto"font from thefont-familyproperty3. main.svelte
min-width: 80%→min-width: 80%;4. text.svelte
needed.App→needed.5. constants.ts
#13172d0→#13172d6. utils.ts (1 fix)
replaced
document.documentElementwithdoc.documentElementto correctly use the passed parameter instead of the global object