Skip to content

Remove unused audit() callbacks from test_config flow files#3171

Merged
talsperre merged 1 commit intomasterfrom
talsperre/remove-unused-audit-functions
May 5, 2026
Merged

Remove unused audit() callbacks from test_config flow files#3171
talsperre merged 1 commit intomasterfrom
talsperre/remove-unused-audit-functions

Conversation

@talsperre
Copy link
Copy Markdown
Collaborator

Summary

The four test/test_config/*.py flow files each defined an audit(run, parameters, configs, stdout_path) callback intended for an in-tree test runner that would execute the flow and post-validate artifacts on the resulting Run. That runner is no longer driving these flows — the validations have moved into the pytest suite — so the audit functions are dead code, along with the imports (json, os) and one helper (find_param_in_parameters in mutable_flow.py) that became unused.

What changed

  • config_simple.py: removed audit(), dropped now-unused import json.
  • config_parser.py: removed audit(), dropped now-unused import json and import os.
  • config_corner_cases.py: removed audit(), dropped now-unused import json.
  • mutable_flow.py: removed audit() + find_param_in_parameters() helper, dropped now-unused import json.

Net: 4 files changed, 205 deletions(-). No behavior change — nothing in the repo imports or calls these functions (verified via grep across the tree).

Test plan

  • python -m py_compile clean on all four files
  • pre-commit run --files test/test_config/{config_simple,config_parser,config_corner_cases,mutable_flow}.py passes (black, AST check, etc.)
  • CI green

🤖 Generated with Claude Code

The four ``test_config/*.py`` flow files each defined an ``audit(run,
parameters, configs, stdout_path)`` callback for the legacy in-tree test
runner that ran the flow and post-validated artifacts. That runner is
no longer driving these flows; the validations have moved into the
pytest suite, so the audit functions and their now-unused ``json`` /
``os`` / ``find_param_in_parameters`` helpers are dead code.

No behavior change: nothing in the OSS repo imports or calls these
functions (verified via grep across the tree).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 4, 2026

Greptile Summary

This PR removes dead code from four test/test_config flow files: the audit() callback functions and their associated unused imports (json, os) and one helper (find_param_in_parameters in mutable_flow.py). The validations previously housed in these callbacks have moved to the pytest suite, and a repo-wide grep confirms no remaining callers exist.

Confidence Score: 5/5

Safe to merge — purely additive dead-code removal with no callers remaining in the repo.

All four changed files are straightforward deletions of unreachable functions and unused imports. No logic is altered, no tests are broken, and no other file in the repository references the removed symbols.

No files require special attention.

Important Files Changed

Filename Overview
test/test_config/config_simple.py Removed unused audit() function and dropped now-unused import json; no functional code changed.
test/test_config/config_parser.py Removed unused audit() function and dropped now-unused import json and import os; no functional code changed.
test/test_config/config_corner_cases.py Removed unused audit() function and dropped now-unused import json; no functional code changed.
test/test_config/mutable_flow.py Removed unused audit() + find_param_in_parameters() helper and dropped now-unused import json; no functional code changed.

Reviews (1): Last reviewed commit: "Remove unused audit() callbacks from tes..." | Re-trigger Greptile

@talsperre talsperre merged commit 4ab2fc0 into master May 5, 2026
45 checks passed
@talsperre talsperre deleted the talsperre/remove-unused-audit-functions branch May 5, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant