Remove unused audit() callbacks from test_config flow files#3171
Remove unused audit() callbacks from test_config flow files#3171
Conversation
The four ``test_config/*.py`` flow files each defined an ``audit(run, parameters, configs, stdout_path)`` callback for the legacy in-tree test runner that ran the flow and post-validated artifacts. That runner is no longer driving these flows; the validations have moved into the pytest suite, so the audit functions and their now-unused ``json`` / ``os`` / ``find_param_in_parameters`` helpers are dead code. No behavior change: nothing in the OSS repo imports or calls these functions (verified via grep across the tree). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Greptile SummaryThis PR removes dead code from four Confidence Score: 5/5Safe to merge — purely additive dead-code removal with no callers remaining in the repo. All four changed files are straightforward deletions of unreachable functions and unused imports. No logic is altered, no tests are broken, and no other file in the repository references the removed symbols. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Remove unused audit() callbacks from tes..." | Re-trigger Greptile |
Summary
The four
test/test_config/*.pyflow files each defined anaudit(run, parameters, configs, stdout_path)callback intended for an in-tree test runner that would execute the flow and post-validate artifacts on the resulting Run. That runner is no longer driving these flows — the validations have moved into the pytest suite — so the audit functions are dead code, along with the imports (json,os) and one helper (find_param_in_parametersinmutable_flow.py) that became unused.What changed
config_simple.py: removedaudit(), dropped now-unusedimport json.config_parser.py: removedaudit(), dropped now-unusedimport jsonandimport os.config_corner_cases.py: removedaudit(), dropped now-unusedimport json.mutable_flow.py: removedaudit()+find_param_in_parameters()helper, dropped now-unusedimport json.Net:
4 files changed, 205 deletions(-). No behavior change — nothing in the repo imports or calls these functions (verified via grep across the tree).Test plan
python -m py_compileclean on all four filespre-commit run --files test/test_config/{config_simple,config_parser,config_corner_cases,mutable_flow}.pypasses (black, AST check, etc.)🤖 Generated with Claude Code