Support images with more than one forward slash#466
Merged
savingoyal merged 2 commits intoNetflix:masterfrom Apr 2, 2021
rchui:fix-docker-tag-parsing
Merged
Support images with more than one forward slash#466savingoyal merged 2 commits intoNetflix:masterfrom rchui:fix-docker-tag-parsing
savingoyal merged 2 commits intoNetflix:masterfrom
rchui:fix-docker-tag-parsing
Conversation
lnaes
approved these changes
Apr 2, 2021
savingoyal
approved these changes
Apr 2, 2021
savingoyal
pushed a commit
that referenced
this pull request
Apr 3, 2021
savingoyal
added a commit
that referenced
this pull request
Apr 22, 2021
* New logging system for Metaflow Work in progress * fixups * more fixups * change environment.py to metaflow_environment.py (#451) * Fix typo in missing job queue error message * extend message * nit * Change environment.py to metaflow_environment.py environment.py clashes with @Environment and results in pylint throwing up a E1102: environment is not callable (not-callable) * Change environment.py to metaflow_environment.py environment.py clashes with @Environment and results in pylint throwing up a E1102: environment is not callable (not-callable) * Fix issues with @Environment (#452) * Fix issues with @Environment context https://gitter.im/metaflow_org/community?at=604a2bfb44f5a454a46cc7f8 * add more comments * roll back to previous commit * Patch version bump for release (#453) * Fix typos (#455) * Fix ordering of custom parameters in help text (#456) * Display custom parameter help-text options in definition order Custom parameters are iteratively inserted into the front of the command parameters list. Doing so in reverse preserves the order in which they are defined in the FlowSpec. * Remove unused import * Comment on help-text ordering fix * Allow more than two slashes to be in a docker image. (#466) * Update metaflow/mflog/mflog.py Co-authored-by: Oleg Avdeev <oleg.v.avdeev@gmail.com> * fixes * fixups * mo' fixes Co-authored-by: David Poznik <dpoznik@users.noreply.github.com> Co-authored-by: Ryan Chui <ryanc@23andme.com> Co-authored-by: Oleg Avdeev <oleg.v.avdeev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address #348.
Explanation (https://regex101.com/r/aPUxUr/1):