Updating interface for server.Listener to support wrapped connections#127
Merged
ScottMansfield merged 1 commit intomasterfrom Dec 21, 2017
Merged
Updating interface for server.Listener to support wrapped connections#127ScottMansfield merged 1 commit intomasterfrom
ScottMansfield merged 1 commit intomasterfrom
Conversation
ScottMansfield
requested review from
deva-jay,
hashbrowncipher,
ipapapa,
senugula,
shailesh33 and
smadappa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured out that some types of connection configurations require returning a wrapped connection, so this interface change adds a return value for the connection along with the error. I also decided (based on previous feedback) that the name ModifyConnSettings was a little verbose and too specific, so that's been changed to Configure.