fix number formatting#94
Merged
copperlight merged 1 commit intoNetflix:mainfrom Dec 21, 2022
copperlight:number-formatting
Merged
fix number formatting#94copperlight merged 1 commit intoNetflix:mainfrom copperlight:number-formatting
copperlight merged 1 commit intoNetflix:mainfrom
copperlight:number-formatting
Conversation
When setting AgeGauges to epoch seconds, such as `1671644992`, the resulting protocol line was `A:gauge:1.67164e+09`, when it is expected to be `A:gauge:1671644992`. The original AgeGauge tests were not setting large enough numbers to discover this formatting issue. Swapping `StrCat` for `StrFormat` and stripping trailing zeroes and decimal places from the resulting number strings produces the output we want. The AgeGauge tests have been updated to use more representative numbers. This change also locks Bazel at version 5.4.0, since there are a number of breaking changes in the 6.0.0 release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting AgeGauges to epoch seconds, such as
1671644992, the resulting protocol line wasA:gauge:1.67164e+09, when it is expected to beA:gauge:1671644992. The original AgeGauge tests were not setting large enough numbers to discover this formatting issue.Swapping
StrCatforStrFormatand stripping trailing zeroes and decimal places from the resulting number strings produces the output we want. The AgeGauge tests have been updated to use more representative numbers.This change also locks Bazel at version 5.4.0, since there are a number of breaking changes in the 6.0.0 release.