improve support for guice#65
Merged
Merged
Conversation
Adds modules that can be used to easily inject the registry with governator for running the actual app or with a test module that creates an isolated registry for unit tests. If the GcLogger is started multiple times it will now log instead of throw. That class needs to be refactored, but that will be a separate PR. For this update the focus is just on making the module work.
Updating the dependencies to reflect direct usage of guice (and governator in tests). This was working before due to transitive dependencies.
brharrington
added a commit
that referenced
this pull request
Nov 14, 2014
improve support for guice
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds modules that can be used to easily inject
the registry with governator for running the
actual app or with a test module that creates
an isolated registry for unit tests.
If the GcLogger is started multiple times it
will now log instead of throw. That class needs
to be refactored, but that will be a separate
PR. For this update the focus is just on making
the module work.