Internalize TAP reporter and ditch “tap-parser”.#11
Merged
theengineear merged 1 commit intomainfrom Apr 21, 2026
Merged
Conversation
theengineear
commented
Apr 21, 2026
| "scripts": { | ||
| "lint": "eslint --max-warnings=0 .", | ||
| "lint-fix": "eslint --fix .", | ||
| "test": "node --test 'test/**/*.test.js'", |
Collaborator
Author
There was a problem hiding this comment.
It’s actually really satisfying to see all the parallels between the default node test runner and our own, browser-based test runner. This project has really helped me understand the exact Venn diagram we are working with :^)
theengineear
commented
Apr 21, 2026
| "lint": "eslint --max-warnings=0 .", | ||
| "lint-fix": "eslint --fix .", | ||
| "test": "node --test 'test/**/*.test.js'", | ||
| "demo": "node demo/index.js", |
Collaborator
Author
There was a problem hiding this comment.
Added a demo suite to make it easier to feel the result locally in the CLI.
theengineear
force-pushed
the
internalize-tap-reporter
branch
3 times, most recently
from
32865ef to
eb1002f
Compare
This is a minimal CLI for a minimal testing library. We can be very targeted about the problems we seek to solve. As such, a _very_ small subset of TAP-parsing functionality is needed — more than would warrant pulling in `tap-parser` at this point. We add `x-test-cli-tap.js` to handle all our TAP-y needs. To keep things interoperable with the previous pass-through output, we allow developers to pass `--reporter=tap` (mimicking Node’s naming). Otherwise, developers now get a stylized output in their terminal. Care was taken to handle cases where developers have indicated (or implied) that they do not _want_ stylized output (e.g., while piping to something like `grep`). Finally, the TAP output _text_ content is not changed, just stylized. I.e., stripping back out the stylization would leave you with the original text from x-test. Closes #4 and closes #7.
theengineear
force-pushed
the
internalize-tap-reporter
branch
from
eb1002f to
e66f4e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal CLI for a minimal testing library. We can be very targeted about the problems we seek to solve. As such, a very small subset of TAP-parsing functionality is needed — more than would warrant pulling in
tap-parserat this point. We addx-test-cli-tap.jsto handle all our TAP-y needs.To keep things interoperable with the previous pass-through output, we allow developers to pass
--reporter=tap(mimicking Node’s naming). Otherwise, developers now get a stylized output in their terminal. Care was taken to handle cases where developers have indicated (or implied) that they do not want stylized output (e.g., while piping to something likegrep).Finally, the TAP output text content is not changed, just stylized. I.e., stripping back out the stylization would leave you with the original text from x-test.
Closes #4 and closes #7.