Folder sync timestamp not honored by Imapsync

[stephdl]

Now we can use a timestamp file to only sync the last messages and to lower the resources needed by imapsync, however if we change of synchronisation method (all, exclusion, inbox) we do not honor the good synchronisation and we still keep to use the last timestamp

Steps to reproduce

• install a account provider, mail and imapsync (1.0.5-dev.3)
• do a sync only inbox
• once synchronized do a full sync
• you only do a full sync from the last day (--maxage=1)

Expected behavior

I expect to do a full sync and not only the mail from the last day

Actual behavior

we use the timestamp of the inbox sync, we should have a specific timestamp for this

Components

ghcr.io/nethserver/imapsync:1.0.5-dev.3

See also

https://mattermost.nethesis.it/nethesis/pl/6b3dh49bspb7pgfax5kay68o6w

[stephdl]

QA

version to test: ghcr.io/nethserver/imapsync:1.0.6-dev.1

case1

• do a first sync from Synchronize all recursively and go the end, the timestamp file of you task gets all inside

/ # cat /etc/imapsync/administrator_ohy8mn.timestamp
all

• do a first sync from Synchronize only INBOX and go the end, the timestamp file of you task gets inbox inside

/ # cat /etc/imapsync/administrator_ohy8mn.timestamp
inbox

• do a first sync from Synchronize with exclusions and go the end, the timestamp file of you task gets exclusion inside

/ # cat /etc/imapsync/administrator_ohy8mn.timestamp
exclusion

case2
once you have been to an end with a sync, inbox for example, the next sync will use the --maxage=1 as argument

case3
start a task and stop it , the timestamp file of the task has been removed

[lucagasparini]

Test case 1: VERIFIED
Test case 2: VERIFIED
Test case 3: VERIFIED

I would like to point out something that I think deserves a new issue.

During test case 1 I noticed that if the source mailbox has shared folders configured, the imapsync task always ends with errors like these:

Mar 14 14:42:47 rl1 imapsync[38836]: Detected 6 errors
Mar 14 14:42:47 rl1 imapsync[38836]: Check if a new imapsync release is available by adding --releasecheck
Mar 14 14:42:47 rl1 imapsync[38836]: Homepage: https://imapsync.lamiral.info/
Mar 14 14:42:47 rl1 imapsync[38836]: ++++ Listing 6 errors encountered during the sync ( avoid this listing with --noerrorsdump ).
Mar 14 14:42:47 rl1 imapsync[38836]: Err 1/6: Could not create folder [Shared] from [Shared/xxxxxxx/INBOX]: 1559 NO [CANNOT] Mailbox can't be created (0.001 + 0.000 secs).
Mar 14 14:42:47 rl1 imapsync[38836]: Err 2/6: Host2 folder Shared: Could not select: 1561 NO Mailbox doesn't exist: Shared (0.001 + 0.000 secs).
Mar 14 14:42:47 rl1 imapsync[38836]: Err 3/6: Could not create folder [Shared/xxxxxxx] from [Shared/xxxxxxx/INBOX]: 1562 NO [NOPERM] Permission denied (0.001 + 0.000 secs).
Mar 14 14:42:47 rl1 imapsync[38836]: Err 4/6: Host2 folder Shared/xxxxxxx: Could not select: 1564 NO Mailbox doesn't exist: Shared/xxxxxxx (0.001 + 0.000 secs).
Mar 14 14:42:47 rl1 imapsync[38836]: Err 5/6: Could not create folder [Shared/xxxxxxx/INBOX] from [Shared/xxxxxxx/INBOX]: 1565 NO [NOPERM] Permission denied (0.001 + 0.000 secs).
Mar 14 14:42:47 rl1 imapsync[38836]: Err 6/6: Host2 folder Shared/xxxxxxx/INBOX: Could not select: 1567 NO Mailbox doesn't exist: Shared/xxxxxxx/INBOX (0.001 + 0.000 secs).
Mar 14 14:42:47 rl1 imapsync[38836]: The most frequent error is ERR_CREATE.
Mar 14 14:42:47 rl1 imapsync[38836]: Exiting with return value 116 (EXIT_ERR_CREATE) 6/50 nb_errors/max_errors PID 196

and consequently the .timestamp file was never created !

I think that shared folders should always be excluded by default