fix(openvpn): ensure RW connection database is merged after package installation#1639
Merged
Conversation
Tbaile
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small change to the
postinstscript for thens-openvpnpackage. It ensures that commands are only executed when not running in a package installation root environment, which is important for correct installation behavior.It also add the execution of an additional command to merge the
/vardatabase records into the storage one, if present.postinstscript inpackages/ns-openvpn/Makefileto run/usr/sbin/ns-openvpnrw-extend-crland/usr/libexec/ns-openvpn/openvpn-merge-connections-dbonly when not in the package installation root, ensuring proper setup after installation.openvpn-merge-connections-dbscript after package installation so that, when the system is updated, records are merged into storage to avoid database read issues (after the update, connection history is read from storage if available).Closes: #1404