Skip to content

Fix DKIM signature when disclaimer is added#51

Merged
DavidePrincipi merged 2 commits intoNethServer:masterfrom
DavidePrincipi:fix-dkim-disclaimer
Jun 13, 2018
Merged

Fix DKIM signature when disclaimer is added#51
DavidePrincipi merged 2 commits intoNethServer:masterfrom
DavidePrincipi:fix-dkim-disclaimer

Conversation

@DavidePrincipi
Copy link
Copy Markdown
Member

@DavidePrincipi DavidePrincipi commented Jun 12, 2018

This PR proposal disables the submission DKIM milter when the optional disclaimer package is installed, and reverts the fix of NethServer/dev#5514

The DKIM signature issue seems due to our Postfix configuration which double signs outbound messages:

  1. the first time with submission_smtpd_milters (used by SMTP port 587)
  2. the second time with non_smtpd_milters (used by sendmail)
[root@vm8 ~]# postconf -n | grep smtpd_milt
non_smtpd_milters = unix:/var/run/opendkim/milter
smtpd_milters = unix:/var/run/rspamd/worker-proxy
submission_smtpd_milters = unix:/var/run/rspamd/worker-proxy, unix:/var/run/opendkim/milter

NethServer/dev#5528

Copy link
Copy Markdown
Contributor

@stephdl stephdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authentication-Results: mx.google.com;
       dkim=neutral (body hash did not verify) header.i=@de-labrusse.fr header.s=default header.b=SG3PqP53;

Sorry but with your change gmail doesn't accept the dkim

# postconf -n | grep smtpd_milt
non_smtpd_milters = unix:/var/run/opendkim/milter
smtpd_milters = unix:/var/run/rspamd/worker-proxy
submission_smtpd_milters = unix:/var/run/rspamd/worker-proxy

Avoid double-signing an outbound message
@DavidePrincipi
Copy link
Copy Markdown
Member Author

Can you "gist" the full message (both headers+body?)

@NethServer NethServer deleted a comment from nethbot Jun 12, 2018
@stephdl
Copy link
Copy Markdown
Contributor

stephdl commented Jun 12, 2018

@DavidePrincipi DavidePrincipi merged commit 87396d9 into NethServer:master Jun 13, 2018
@DavidePrincipi DavidePrincipi deleted the fix-dkim-disclaimer branch June 13, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants