Fix DKIM signature when disclaimer is added#51
Merged
DavidePrincipi merged 2 commits intoNethServer:masterfrom Jun 13, 2018
Merged
Fix DKIM signature when disclaimer is added#51DavidePrincipi merged 2 commits intoNethServer:masterfrom
DavidePrincipi merged 2 commits intoNethServer:masterfrom
Conversation
stephdl
reviewed
Jun 12, 2018
Contributor
There was a problem hiding this comment.
Authentication-Results: mx.google.com;
dkim=neutral (body hash did not verify) header.i=@de-labrusse.fr header.s=default header.b=SG3PqP53;
Sorry but with your change gmail doesn't accept the dkim
# postconf -n | grep smtpd_milt
non_smtpd_milters = unix:/var/run/opendkim/milter
smtpd_milters = unix:/var/run/rspamd/worker-proxy
submission_smtpd_milters = unix:/var/run/rspamd/worker-proxy
Avoid double-signing an outbound message
This reverts commit c8dcecc.
d7aa9c0 to
d7cec35
Compare
Member
Author
|
Can you "gist" the full message (both headers+body?) |
Member
Contributor
gsanchietti
approved these changes
Jun 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposal disables the submission DKIM milter when the optional disclaimer package is installed, and reverts the fix of NethServer/dev#5514
The DKIM signature issue seems due to our Postfix configuration which double signs outbound messages:
submission_smtpd_milters(used by SMTP port 587)non_smtpd_milters(used bysendmail)NethServer/dev#5528