Skip to content

change to code within bin/snap2js#147

Merged
brollb merged 1 commit intoNetsBlox:145-windows-supportfrom
byett:145-windows-support
Aug 19, 2021
Merged

change to code within bin/snap2js#147
brollb merged 1 commit intoNetsBlox:145-windows-supportfrom
byett:145-windows-support

Conversation

@byett
Copy link
Copy Markdown

@byett byett commented Jun 17, 2021

No description provided.

@brollb
Copy link
Copy Markdown
Contributor

brollb commented Jul 28, 2021

I am a bit puzzled about this. Can't you require files using / in windows when using node's require? Why does this need to be changed to \?

@byett
Copy link
Copy Markdown
Author

byett commented Jul 28, 2021

That may work as well - this was just the solution I could come up with after doing some research into similar issues.

@brollb brollb merged commit 6bdb896 into NetsBlox:145-windows-support Aug 19, 2021
@brollb
Copy link
Copy Markdown
Contributor

brollb commented Aug 19, 2021

This seems to work on linux so it should be good to go! (I admit I am counting on your testing on windows since you were the OP of the issue :) ).

@brollb brollb mentioned this pull request Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants