Example Script Dockerfile #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheConnMan
requested review from
Grumblesmith,
markstarbuck,
rclagett and
shawnbutts
shawnbutts
reviewed
Feb 10, 2017
| RUN python setup.py test | ||
| RUN python setup.py install | ||
|
|
||
| RUN ln -sf /usr/share/zoneinfo/UTC /etc/localtime |
Contributor
There was a problem hiding this comment.
why are you setting this here and on line 6?
Contributor
Author
There was a problem hiding this comment.
The tests fail when run with the timezone set to UTC (#9) then the samples and events don't respect this timezone when sent in so they are 5 hours in the future if I don't set it back to UTC. I wanted to see if I was doing something incorrectly before I made the latter issue a GitHub issue.
shawnbutts
reviewed
Feb 10, 2017
Dockerfile
Outdated
| RUN ln -sf /usr/share/zoneinfo/UTC /etc/localtime | ||
|
|
||
| ENV API_URL https://api.app.netuitive.com/ingest | ||
| ENV CUSTOM_API_KEY change-me |
Contributor
There was a problem hiding this comment.
can your changes this to change-me-apikey or something else that has apikey in it? this will help with blocking misconfigured clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.