Skip to content

fix resetting internal _metrics during clear samples and adding samples #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yahonggu merged 1 commit into from
Feb 16, 2018
Merged

fix resetting internal _metrics during clear samples and adding samples #23

yahonggu merged 1 commit into from
Feb 16, 2018

Conversation

@yahonggu
Copy link
Contributor

@yahonggu yahonggu commented Feb 16, 2018

this is a bug found during netuitive-statsd testing using python client v0.3.1

@coveralls
Copy link

coveralls commented Feb 16, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 99.184% when pulling 6dfb922 on bugfix/internal-metrics-cleanup into b80c163 on develop.

@yahonggu yahonggu merged commit db32603 into develop Feb 16, 2018
@yahonggu yahonggu deleted the bugfix/internal-metrics-cleanup branch February 16, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bspindler bspindler bspindler approved these changes

+1 more reviewer

@TheConnMan TheConnMan TheConnMan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yahonggu @coveralls @bspindler @TheConnMan