Allow limited RLIMIT_FSIZE when dumping lease #389
Merged
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set rlimit to 5Kb when dumping lease (all other privileges are still dropped). Without this, redirecting dumplease to anything but stdout results in SIGXFSZ due to EBIG error.
Contributor
Author
|
Note this will still not let you dump lease as part of an exit hook script, those are still limited to FSIZE 0. |
If it's not, we can't set it.
Member
|
@ColinMcInnes I made the fix a bit simpler. Does it still work for you? |
Contributor
Author
Yes that works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PRIVSEP, set rlimit to 5Kb when dumping lease (all other privileges are still dropped).
Without this, redirecting dumplease to anything but stdout results in SIGXFSZ due to EBIG error.
Resolves #386