2020 Update #12
Merged
2020 Update #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to use wheel.
This project is merged with setuptools.
Contributor
Author
|
cc @madtibo |
Collaborator
|
The changes look good. I'll want to try it out once with a new venv to make sure that nothing silly breaks and merge it in. re: the documentation; I would want to keep the explicit list of tables instead of showing just one for the sake of completeness. Could you make that change @bersace? Thanks! |
Document a quickstart setup first and then describe advanced usage for custom tables.
Contributor
Author
|
Hi @musically-ut thanks for the review ! You're right, I updated the README to document supported tables by Feel free to nitpick :-) |
Contributor
Author
|
🆙 |
Also, removed mention of unnecessary dependency which was installed for Python 2x support.
Remove wsgiref which was required for Python 2 support.
Collaborator
|
Thanks! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for this great project :-)
I found some rough edge and though I could polish the project. Here is my contribution.
What do you think of this ?