Coerce lists/arrays to the expected ArrayParameter subtype in ParameterSpace#832
Merged
apdavison merged 1 commit intoNeuralEnsemble:masterfrom May 5, 2026
Merged
Conversation
…erSpace When the schema specifies a subclass of ArrayParameter (e.g. Sequence), _setitem_value was hardcoding ArrayParameter as the coercion target. This meant passing a list of numpy arrays as spike_times would produce ArrayParameter elements rather than Sequence elements, causing .get() to fail. Fix by using expected_dtype in all three coercion branches. Fixes NeuralEnsemble#709
|
coverage: 71.146% (-0.008%) from 71.154% — apdavison:issue709 into NeuralEnsemble:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the schema specifies a subclass of ArrayParameter (e.g. Sequence), _setitem_value was hardcoding ArrayParameter as the coercion target. This meant passing a list of numpy arrays as spike_times would produce ArrayParameter elements rather than Sequence elements, causing .get() to fail. Fix by using expected_dtype in all three coercion branches.
Fixes #709