-
Notifications
You must be signed in to change notification settings - Fork 262
Spikeglx np2 #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JuliaSprenger
merged 12 commits into
NeuralEnsemble:master
from
samuelgarcia:spikeglx_np2
Jan 20, 2022
Merged
Spikeglx np2 #1045
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
322029b
Handle channel gain for NP2.0 in SpikeGLXRawio
samuelgarcia 9114fae
remove channel location because it was wrong. This is done correctly …
samuelgarcia c2a90b5
add load_sync_channel to not expose the last channel (SY0)
samuelgarcia dc9027a
Make test on new files and fix bugs.
samuelgarcia 653b206
Some clean
samuelgarcia 3255ef2
some bug fix for spikeinterface case
samuelgarcia dac2916
fix gain bug due to bad ident
samuelgarcia 3095a57
Fix some gain for NP 2.0 and take in account for metadata version.
samuelgarcia b2e6718
codestyle
samuelgarcia f3d8424
Add back channel locations with probeinterface dependency.
samuelgarcia 7b712ef
Propagate to SpikeGLXIO
samuelgarcia ff6e90e
oups
samuelgarcia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,3 +14,4 @@ coveralls | |
pillow | ||
sonpy | ||
pynwb | ||
probeinterface |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this then maybe raise a warning if the info metadata and the data length don't match?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samuelgarcia What is your opinion about this?