Skip to content

[NWBIO] Add a warning to avoid signals with the same name #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 26, 2022
Merged

[NWBIO] Add a warning to avoid signals with the same name #1054

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dbbdaf8
Add a warning to avoid signals with the same name
legouee Dec 7, 2021
afde97a
Add a warning to avoid signals with the same name
legouee Dec 7, 2021
0aa7e65
test skiprows
legouee Dec 17, 2021
a1b0294
test usecols
legouee Dec 17, 2021
565fdc8
Merge branch 'master' of github.com:NeuralEnsemble/python-neo into Co…
legouee Jan 25, 2022
8f28a23
Similar structure names
legouee Jan 25, 2022
ee8913c
remove unrelated tests
legouee Jan 25, 2022
667401e
fix pep8
legouee Jan 25, 2022
b44003f
Update test_asciisignalio.py
legouee Jan 25, 2022
80cc13d
Update test_asciisignalio.py
legouee Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions neo/io/nwbio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,9 +517,11 @@ def _write_segment(self, nwbfile, segment, electrodes):
for i, signal in enumerate(
chain(segment.analogsignals, segment.irregularlysampledsignals)):
assert signal.segment is segment
signal.name = "%s %s %i" % (signal.name, segment.name, i)
if not signal.name:
signal.name = "%s : analogsignal%d %i" % (segment.name, i, i)
if hasattr(signal, 'name'):
signal.name = "%s %s %i" % (segment.name, signal.name, i)
logging.warning("Warning signal name exists. New name: %s" % (signal.name))
else:
signal.name = "%s : analogsignal%s %i" % (segment.name, signal.name, i)
self._write_signal(nwbfile, signal, electrodes)

for i, train in enumerate(segment.spiketrains):
Expand All @@ -530,9 +532,11 @@ def _write_segment(self, nwbfile, segment, electrodes):

for i, event in enumerate(segment.events):
assert event.segment is segment
event.name = "%s %s %i" % (event.name, segment.name, i)
if not event.name:
event.name = "%s : event%d" % (segment.name, i)
if hasattr(event, 'name'):
event.name = "%s %s %i" % (segment.name, event.name, i)
logging.warning("Warning event name exists. New name: %s" % (event.name))
else:
event.name = "%s : event%s %d" % (segment.name, event.name, i)
self._write_event(nwbfile, event)

for i, epoch in enumerate(segment.epochs):
Expand Down