Remove reference to all_data property in docstring of class Segment #1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the reference to the
all_dataproperty in the docstring of the neo.core.Segment class.python-neo/neo/core/segment.py
Line 65 in ac0d9e6
In pull request #143, the
all_dataproperty was removed from the class, but the description of the property remained in the docstring. This could be confusing for users who come across the docstring and try to use the all_data property, which is no longer available.This change does not affect the functionality of the code, but it will improve the clarity and accuracy of the documentation, which is why I considered to add this here.
Feel free to close this PR any time, this is just meant to inform you about this finding. 🙂