Blackrock make sampling rate a class attribute. #1685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zm711
reviewed
Apr 8, 2025
| rawmode = "multi-file" | ||
|
|
||
| # We need to document the origin of this value | ||
| main_sampling_rate = 30000.0 |
Contributor
There was a problem hiding this comment.
Yeah I'm not sure about this. Black rock has so many versions. I would want a link to docs or something to indicate this is the required. Most software gives you some options.
Contributor
Author
There was a problem hiding this comment.
Note that this was already hardcoded. This is only to make it accessible without parsing.
Contributor
|
This is ok for me |
zm711
approved these changes
Apr 10, 2025
Contributor
zm711
left a comment
zm711
left a comment
There was a problem hiding this comment.
Good by me for now, but hopefully we figure this out. Thanks for adding the note. I get it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this available without the need to parse the header.
SpikeInterface/spikeinterface#3843