-
Notifications
You must be signed in to change notification settings - Fork 265
Blackrock rawio fix overflow #1690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blackrock rawio fix overflow #1690
Conversation
|
it looks like this is a recurrent bug for Blackrock rawio, I'm not sure how to fix it for good, though |
|
Yes @luiztauffer! This is because file sizes are finally big enough to trigger a bunch of overflows that we didn't know about before. We are going to have to do this alot, but we haven't made a big effort yet. Let me fix our text suite first :) Then we can check. EDIT: I vaguely remember that NumPy 2+ was also going to change how they deal with some overflows between OSs so that might also be revealing more of these previously hidden overflow issues. |
|
Once we merge #1691 then we can merge that into this and that will fix testing. Then I'll merge this one ! |
|
While we wait for the tests to finish. Do you want me to add you to the author list and if so which affiliations do you want listed? |
zm711
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
|
@luiztauffer just wanted to swing back around. Did you want to be listed in the author list and which affiliation did you want listed ? |
|
@zm711 sure, thanks for asking! You can add CatalystNeuro as my affiliation |
fix #1689