Skip to content

Conversation

@luiztauffer
Copy link
Contributor

@luiztauffer luiztauffer commented Apr 23, 2025

fix #1689

@luiztauffer
Copy link
Contributor Author

luiztauffer commented Apr 23, 2025

it looks like this is a recurrent bug for Blackrock rawio, I'm not sure how to fix it for good, though

@h-mayorquin @samuelgarcia @zm711

@zm711
Copy link
Contributor

zm711 commented Apr 23, 2025

Yes @luiztauffer! This is because file sizes are finally big enough to trigger a bunch of overflows that we didn't know about before. We are going to have to do this alot, but we haven't made a big effort yet. Let me fix our text suite first :) Then we can check.

EDIT: I vaguely remember that NumPy 2+ was also going to change how they deal with some overflows between OSs so that might also be revealing more of these previously hidden overflow issues.

@zm711
Copy link
Contributor

zm711 commented Apr 23, 2025

Once we merge #1691 then we can merge that into this and that will fix testing. Then I'll merge this one !

@zm711
Copy link
Contributor

zm711 commented Apr 24, 2025

While we wait for the tests to finish. Do you want me to add you to the author list and if so which affiliations do you want listed?

Copy link
Contributor

@zm711 zm711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@zm711 zm711 merged commit 129da57 into NeuralEnsemble:master Apr 24, 2025
5 checks passed
@luiztauffer luiztauffer deleted the fix-blackrock-overflow branch April 24, 2025 12:57
@zm711
Copy link
Contributor

zm711 commented May 5, 2025

@luiztauffer just wanted to swing back around. Did you want to be listed in the author list and which affiliation did you want listed ?

@zm711 zm711 modified the milestones: 0.14.1, 0.14.2 May 5, 2025
@luiztauffer
Copy link
Contributor Author

@zm711 sure, thanks for asking! You can add CatalystNeuro as my affiliation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blackrock ns6 OverflowError: Python integer out of bounds for uint32

2 participants