Skip to content

Conversation

@samuelgarcia
Copy link
Contributor

No description provided.

@samuelgarcia
Copy link
Contributor Author

This need to merged before #824

@samuelgarcia
Copy link
Contributor Author

@MarinManuel @JuliaSprenger : I prefer this fix for channel names.
The 'U' is now official.

@JuliaSprenger
Copy link
Member

I think there are a still a number of places in the code, where 'S' is used instead of 'U', e.g.

channel_names=np.array(['Chan1'], dtype='S'))

These are not affecting the functionality, since the type is anyway converted later, but maybe it would make sense to systematically replace 'S' by 'U' also in all non-relevant places?

@samuelgarcia
Copy link
Contributor Author

I think I already fix the brainwaredamio no ?
Test are passing so I think there is no channelindex.channel_names with 'S' anymore.
Each object read by IOs are tested for there types and dtypes normally.
What do you think of this solution ?

@JuliaSprenger
Copy link
Member

Yes, you are right, I missed that one. Looks good to me!
Thanks for the fix.

@JuliaSprenger JuliaSprenger merged commit b6cf445 into NeuralEnsemble:master Jun 16, 2020
@samuelgarcia samuelgarcia deleted the fix_chan_name_str branch March 9, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants