-
Notifications
You must be signed in to change notification settings - Fork 266
Fixes to make tests pass with Pegasus event files only directory. #851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to make tests pass with Pegasus event files only directory. #851
Conversation
|
Hello @PeterNSteinmetz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-28 15:42:23 UTC |
|
Many thanks for this PR. Please also add your name and affiliation to |
|
Hi Peter, |
|
It is definitely easy to revert the change of the local argument name to channel_indices if that is what people want. Since this is a name simply local to the function and makes no difference to the caller, I would suggest just gradually changing this spelling in functions as they are changed for other reasons. |
|
Bumping this. Can I get some advice on use of channel_indices for local argument names in non-public functions, i.e., those beginning with _ ? I can then change this in both of my current pull requests. |
|
Hi @PeterNSteinmetz, thanks for the the PR . Look good to me. Please just revert the name changes for |
JuliaSprenger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a number of TODO notes in your changes. Are you planning to address these in this PR, i.e. is this PR still work in progress?
The use of channel_indexes is a standard throughout neo at present.
|
Appears now to past all tests and should be ready to merge. |
This set of changes fixes a bug which prevented the Pegasus .Nev event only files from passing the test suite.
It also allows filename extensions to be in any letter case. For the InputInverted header parameter to be missing,
meaning not inverted. Checks for 8 hashes at the start of the header as a check on header contents. Allows
any whitespace between a header key and value.
Internal changes are addition of a large number of explanatory comments and refactoring of the code to handle
the header into a separate class. Many of these in preparation for handling earlier versions of neuralynx file headers
and more flexible handling of segments withins .Ncs files.