Skip to content

Conversation

@PeterNSteinmetz
Copy link
Contributor

@PeterNSteinmetz PeterNSteinmetz commented Oct 30, 2020

Provides some fixes and test data for BML style Neuralynx .ncs files which have fractional sampling frequencies and microsPerSamp.

Best merged here after PR #890 is merged.

This will not pass integrations tests until GIN PR #23 is merged into master there.

Peter N. Steinmetz added 30 commits September 8, 2020 11:52
Allows full normal testing to run, using the 4.0.2 data only to test the parsing of ncs recording from the header information.
Tests for v5.5.1 still failing.
…ssignement.

Using a tolerance over a longer experiment is not sensitive enough to detect blocks where perhaps a large amount of samples are dropped and there is a small gap afterwards.
@pep8speaks
Copy link

Hello @PeterNSteinmetz! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 540:66: W504 line break after binary operator
Line 541:72: W504 line break after binary operator
Line 542:68: W504 line break after binary operator
Line 597:32: W504 line break after binary operator
Line 639:25: E116 unexpected indentation (comment)
Line 667:82: W504 line break after binary operator
Line 779:82: W504 line break after binary operator
Line 801:45: E126 continuation line over-indented for hanging indent
Line 844:41: E126 continuation line over-indented for hanging indent
Line 850:41: E126 continuation line over-indented for hanging indent
Line 875:45: E126 continuation line over-indented for hanging indent

@PeterNSteinmetz
Copy link
Contributor Author

Ignoring these line break and indent PEP8 comments as before.

@PeterNSteinmetz
Copy link
Contributor Author

This should pass tests when gin pull request #23 is merged into master there.

@apdavison apdavison added this to the 0.10.0 milestone Nov 9, 2020
@PeterNSteinmetz
Copy link
Contributor Author

Holding off on creating other pull requests until the preceding and this are merged into base master. There has started to be too much divergence.

@JuliaSprenger
Copy link
Member

Hi @PeterNSteinmetz, sorry for the delay, we are in the process of making a new release, so there's a quite a bit moving currently. I will come back to you when things have settled again.

@PeterNSteinmetz
Copy link
Contributor Author

Closed and incorporated into new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants