-
Notifications
You must be signed in to change notification settings - Fork 266
[NeuralynxRawIO] Test data and fixes for BML style ncs files. #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NeuralynxRawIO] Test data and fixes for BML style ncs files. #891
Conversation
Allows full normal testing to run, using the 4.0.2 data only to test the parsing of ncs recording from the header information.
Tests for v5.5.1 still failing.
…ssignement. Using a tolerance over a longer experiment is not sensitive enough to detect blocks where perhaps a large amount of samples are dropped and there is a small gap afterwards.
Strange this hasn’t caused issues before with other file sets.
|
Hello @PeterNSteinmetz! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
|
Ignoring these line break and indent PEP8 comments as before. |
|
This should pass tests when gin pull request #23 is merged into master there. |
|
Holding off on creating other pull requests until the preceding and this are merged into base master. There has started to be too much divergence. |
|
Hi @PeterNSteinmetz, sorry for the delay, we are in the process of making a new release, so there's a quite a bit moving currently. I will come back to you when things have settled again. |
|
Closed and incorporated into new PR. |
Provides some fixes and test data for BML style Neuralynx .ncs files which have fractional sampling frequencies and microsPerSamp.
Best merged here after PR #890 is merged.
This will not pass integrations tests until GIN PR #23 is merged into master there.