Adapt to API change of h5py version 3.0 #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'.value' was removed in favour of '[()]'
Contributor
|
Cool. |
Member
Author
|
I added a minimal requirement of h5py version 2.6 which is 4 years old, as at least locally this seemsstill compatible with the new implementation. |
Member
Author
|
Finally travis tests finished. Ready from my side. |
Member
Author
|
@samuelgarcia Any more suggestions for improvements? |
Contributor
|
What I saw everywhere is that this HDF5 version 3.0 broke lot of libs. Is it the only faillure we have ? |
Member
Author
|
I think we should merge this now as this is currently breaking the master branch and add a circleci coverage with h5py==2.6 in another PR. |
Contributor
|
OK I merge |
This was referenced Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently hdf5io unittests are broken due to an update in the h5py API.
This PR fixes the IO by extending the first fix implemented in #892