Skip to content

feat(ui): show the session title in the tab bar#340

Open
pascalandr wants to merge 2 commits intoNeuralNomadsAI:devfrom
Pagecran:fix/show-session-title
Open

feat(ui): show the session title in the tab bar#340
pascalandr wants to merge 2 commits intoNeuralNomadsAI:devfrom
Pagecran:fix/show-session-title

Conversation

@pascalandr
Copy link
Copy Markdown
Contributor

@pascalandr pascalandr commented Apr 18, 2026

Fixes #299

Summary

  • show the active session title in the instance tab bar, just after the + button
  • only show that title when the left session drawer is closed, so it adds context without duplicating what is already visible in the sidebar
  • keep the message header focused on status and controls

Validation

  • npm run build --workspace @codenomad/ui
  • visually validated in the desktop app

Render the current session title in the instance header for both compact and regular layouts, while keeping the existing status indicators and command controls in place.
Display the active session title next to the new-tab control, and only when the left session drawer is closed so the title adds context without competing with the sidebar.
@pascalandr pascalandr changed the title feat(ui): show the active session title in the header feat(ui): show the session title in the tab bar Apr 18, 2026
@pascalandr
Copy link
Copy Markdown
Contributor Author

@CodeNomadBot

I want you to perform the gatekeeper checks for latest PR state

check for regressions
check for better possible implementations
Be the PR gatekeeper
Be ruthless about code quality

@codenomadbot
Copy link
Copy Markdown
Contributor

codenomadbot Bot commented Apr 18, 2026

Gatekeeper review for the latest PR state.

Assumption: you wanted a strict review pass on the current branch state, focused on regressions and implementation quality, not additional code changes.

Findings

No blocking regressions stood out in the current diff.

Non-blocking concerns / things to confirm

  1. packages/ui/src/App.tsx:243-260
    The tab-bar session title is derived only when activeAppTab() is an instance tab. If a sidecar tab is active, activeInstance() becomes null, so the session title disappears entirely. That may be intentional, but it is the main UX edge case I would verify because the tab bar still remains visible and the user may still expect session context there.

  2. packages/ui/src/components/instance/instance-shell2.tsx:92
    This file is already very large at roughly 975 lines. The current change is small and acceptable, but it increases the prop/effect surface of an already oversized component. I would not block on that here, but it is a maintainability hotspot.

Validation

I attempted the PR’s stated build check:
npm run build --workspace @codenomad/ui

That could not run in this bot environment because the workspace dependencies are not installed here. The failure was environment-level, not a code-level type/build error from this diff:
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'vite'

Bottom line

From a code review standpoint, I do not see a blocker in the implementation as submitted. The only thing I would explicitly confirm before merge is the sidecar-tab behavior described above.

--
Yours,
CodeNomadBot

@shantur
Copy link
Copy Markdown
Collaborator

shantur commented Apr 19, 2026

@pascalandr - Thanks for working on this.

I think the best would be to show the session title in the session view header instead of the tab bar. It gives a better mental model. I do need to relayout the header anyway so I can implement as part of that work if that's ok.

@pascalandr
Copy link
Copy Markdown
Contributor Author

@shantur
What about merging this while waiting for your relayout of the header, and drop it when you're ready ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add show session title

2 participants