Conversation
Member
Author
|
I removed the "restart server" action - I thought the generated web page are static only, why do we need to restart? also, I see you were exporting the private key to a file. I feel this could leak the key in the future if we are not careful. is this restart step really necessary? |
Member
Author
|
patch already included in #22, closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi @MarSH-Up, I debugged the sftp action and have to do the following to fix the broken action
wlixcc/SFTP-Deploy-Actionto NeuroJSON org solved the repo error - I have no idea why it triggers this error despite that this action is already in the Github marketplace, maybe because this is a private repo?-m pemwith ssh-keygen, so that the output is in the pem format (which has a header ofBEGIN RSA PRIVATE KEY)authorized_keysfileafter the above 3 changes, the action now works
although the built webpage can be uploaded to zodiac, but the page is empty, you can take a look, I will create another issue on this (#20)
https://zodiac.coe.neu.edu/dev/dev_fang/
the body of the index.html file shows "You need to enable JavaScript to run this app."
please take a look and merge to your branch. after we fix the empty page problem, feel free to push it to staging.