Skip to content

Update AUTHORS.txt#20

Merged
fangq merged 1 commit intoNeuroJSON:masterfrom
sertansenturk:patch-1
Jan 26, 2016
Merged

Update AUTHORS.txt#20
fangq merged 1 commit intoNeuroJSON:masterfrom
sertansenturk:patch-1

Conversation

@sertansenturk
Copy link
Copy Markdown
Contributor

Adding Sertan Senturk's contact details

Adding Sertan Senturk's contact details
@sertansenturk
Copy link
Copy Markdown
Contributor Author

@fangq I haven't realized that you have also added my name to the authors. I simply wanted to use this pull request as an excuse to thank you :)

fangq added a commit that referenced this pull request Jan 26, 2016
@fangq fangq merged commit 92be8b9 into NeuroJSON:master Jan 26, 2016
@fangq
Copy link
Copy Markdown
Member

fangq commented Jan 26, 2016

you are welcome!

by the way, have you seen this comment from Jana on 12 Jan 2016:

http://www.mathworks.com/matlabcentral/fileexchange/33381-jsonlab--a-toolbox-to-encode-decode-json-files-in-matlab-octave

it looks like there is a bug in object2json. I asked the reporter to create a new issue, but this has not happened yet. will ping you once I have a test script to reproduce the problem.

@sertansenturk
Copy link
Copy Markdown
Contributor Author

No haven't seen that. Thanks for letting me know.

Hard to tell which specific line was the problem but with the simple code
I've added, I suspect the input is rather a big object with many properties
with nesting. I cannot think of a way to solve this problem.

Another guess I have is the "special" objects which inherit classes in
MATLAB such as the handle objects, Listeners etc. I have tested my code on
handle objects as far as I remember, but didn't test it on other specific
cases.

Anyways it is hard know the problem, without specific information. Please
tell me if you can reproduce the problem and I will give my best to fix
it...

On Tue, Jan 26, 2016 at 5:27 AM, Qianqian Fang notifications@github.com
wrote:

you are welcome!

by the way, have you seen this comment from Jana on 12 Jan 2016:

http://www.mathworks.com/matlabcentral/fileexchange/33381-jsonlab--a-toolbox-to-encode-decode-json-files-in-matlab-octave

it looks like there is a bug in object2json. I asked the reporter to
create a new issue, but this has not happened yet. will ping you once I
have a test script to reproduce the problem.


Reply to this email directly or view it on GitHub
#20 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants