security: enforce RBAC on all entity CRUD handlers#44
Merged
NeuroKoder3 merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
…bility) The entity:create, entity:get, entity:update, entity:delete, entity:list, and entity:filter IPC handlers previously only checked session validity, allowing any authenticated user (including viewers) to mutate data. Now every handler calls enforcePermission() which checks the user's role against the RBAC matrix in accessControl.cjs before allowing the operation. Each entity type maps to specific permissions for view/create/update/delete actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Broken Access Control (BAC) vulnerability — the last critical security gap identified in the enterprise production readiness assessment.
Before: The entity CRUD handlers only checked whether a session was active. Any authenticated user — including viewers and regulators — could create, modify, or delete any entity type by calling the IPC channel directly.
After: Every handler now calls enforcePermission before proceeding. This function checks the user role against the RBAC permission matrix defined in accessControl.cjs.
Permission mapping covers all 14 entity types:
Test plan