-
Notifications
You must be signed in to change notification settings - Fork 34
Refactor ObjectView validation #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… validation function
- Made target visible property of SoftLink - Added dereferenced object to target property when calling deref. - Added static method to temporary disable path deprecation warning.
Also, disable path deprecation warning for SoftLinks, as this is necessary when reading NWB files
Added function for validating reference types
Add proper validation function for ObjectView/RegionView properties when filling validator methods of generated classes
(re)Added condition for skipping validation of empty value
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
- Coverage 94.99% 94.96% -0.03%
==========================================
Files 169 170 +1
Lines 5993 6017 +24
==========================================
+ Hits 5693 5714 +21
- Misses 300 303 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Updated variable names for better consistency - Created separate function isReferenceType for clearer intent - Created separate function getReferenceTypeClassName to remove duplicate code
Minor changes
3 tasks
bendichter
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix ObjectView validation, using similar strategies as for validation of SoftLinks.
Changes:
How to test the behavior?
Checklist
fix #XXwhereXXis the issue number?