Skip to content

Conversation

@ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Aug 7, 2025

Motivation

Fix ObjectView validation, using similar strategies as for validation of SoftLinks.

Changes:

  • Validate ObjectView and the target type.
  • Allow specifying a target type directly (and wrap it in an ObjectView type internally)

How to test the behavior?

Show here how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

- Made target visible property of SoftLink
- Added dereferenced object to target property when calling deref.
- Added static method to temporary disable path deprecation warning.
Also, disable path deprecation warning for SoftLinks, as this is necessary when reading NWB files
Added function for validating reference types
Add proper validation function for ObjectView/RegionView properties when filling validator methods of generated classes
(re)Added condition for skipping validation of empty value
@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 91.22807% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.96%. Comparing base (6530e80) to head (4d3ec03).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
+types/+util/validateReferenceType.m 80.00% 3 Missing ⚠️
+file/fillValidators.m 95.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
- Coverage   94.99%   94.96%   -0.03%     
==========================================
  Files         169      170       +1     
  Lines        5993     6017      +24     
==========================================
+ Hits         5693     5714      +21     
- Misses        300      303       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Updated variable names for better consistency
- Created separate function isReferenceType for clearer intent
- Created separate function getReferenceTypeClassName to remove duplicate code
@ehennestad ehennestad marked this pull request as ready for review August 8, 2025 09:10
@ehennestad ehennestad merged commit 4db9de7 into main Aug 14, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants