Replace deprecated numpy aliases of builtin types#142
Closed
grahamfindlay wants to merge 1 commit intoNeuroinflab:masterfrom
Closed
Replace deprecated numpy aliases of builtin types#142grahamfindlay wants to merge 1 commit intoNeuroinflab:masterfrom
grahamfindlay wants to merge 1 commit intoNeuroinflab:masterfrom
Conversation
abukaj
suggested changes
Sep 14, 2023
Member
abukaj
left a comment
abukaj
left a comment
There was a problem hiding this comment.
Scope of code changes is much broader than declared in PR. Most of them seems to be cosmetic and code-style related. Please narrow code changes and/or explain them in the PR.
Member
|
Note that d816da7 fixes at least some of deprecated aliases. |
Collaborator
|
These have now been fixed with the #151 merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #141