Fix open redirect vulnerability in login controller

[Copilot]

Addresses security vulnerability where unauthenticated $_POST['redirect_url'] could redirect users to external malicious sites after successful login.

Changes

• Added isValidRedirectUrl() validation method that only permits relative URLs starting with /, blocks protocol-relative URLs (//example.com), and rejects malicious patterns (@, \)
• Updated login() method to validate redirect URL before using it, falling back to /admin/dashboard if validation fails

Example

// Before: Direct usage of unvalidated user input
$RedirectUrl = $_POST['redirect_url'] ?? '/admin/dashboard';
header( 'Location: ' . $RedirectUrl );

// After: Validation prevents open redirect
$requestedRedirect = $_POST['redirect_url'] ?? '/admin/dashboard';
$RedirectUrl = $this->isValidRedirectUrl( $requestedRedirect )
    ? $requestedRedirect
    : '/admin/dashboard';
header( 'Location: ' . $RedirectUrl );

Attacker-supplied URLs like https://evil.com or //phishing-site.com will now be rejected, defaulting to the safe dashboard route.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Note

Free review on us!

CodeRabbit is offering free reviews until Fri Nov 07 2025 to showcase some of the refinements we've made.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}