Allow custom output directory for downloaded plugins and builds.#32
Merged
NewAmazingPVP merged 2 commits intoNewAmazingPVP:mainfrom Oct 14, 2025
Merged
Allow custom output directory for downloaded plugins and builds.#32NewAmazingPVP merged 2 commits intoNewAmazingPVP:mainfrom
NewAmazingPVP merged 2 commits intoNewAmazingPVP:mainfrom
Conversation
Refactored sanitizeCustomPath in PluginDownloader and PluginUpdater to use java.nio path normalization and handle InvalidPathException. Added support for expanding '~' to the user's home directory. Updated ensureDir to use File.separator and improved directory creation logic.
Owner
|
@TubYoub Hello there, Thank you so much for the PR! I have wanted to add this feature for a long time! I also believe it would be useful if users could use this feature to install plugins outside the server root, and I have maintained your path compatibility without the "/" but added absolute path support as well. I will go ahead and merge this PR! Thank you again for the PR, and I apologize for the delay in merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was frustrated to always manually update my Geyser Extensions, so I added this small change to include the functionality to set a custom download path.
The way to add a custom download path is as follows:
<name>:<link> | <path>MCXB: "https://github.com/MCXboxBroadcast/Broadcaster | plugins/Geyser-Velocity/extensions/"To prevent users from going outside the server directory, the first "/" is removed from the path.