Watershed group x ecoregion overlap section + canonical 16-WSG list#51
Merged
Conversation
…t to 16 New "Watershed Groups Across Ecoregions" section in the peace-fwcp vignette: a map of the 16 canonical FWCP Peace watershed groups labelled with their codes on top of ecoregion fills, plus a table showing the percent of each watershed group's area that falls in each of the five ecoregions. Lets readers map per-ecoregion climate departure findings (precipitation up only in BMP and NRM) onto the watershed-group reporting unit. Canonical 16-WSG list hardcoded in data-raw/example_context_fwcp_peace.R: CARP, CRKD, FINA, FINL, FIRE, FOXR, INGR, LOMI, MESI, NATR, OSPK, PARA, PARS, PCEA, TOOD, UOMI. Each is >=99% inside the FWCP polygon. Drops UPCE (only 11.8% inside; main drainage runs east past FWCP) and MURR (1% sliver). Aligns with the shared GIS project tracking. Other improvements rolled in: - Recent vs Pre-warming consolidated to one table (variable, period, recent mean, pre-warming mean, abs diff, % change, trend p) instead of two near-redundant tables. Plain-language interp paragraph states the temperature/VPD/precipitation/SM signals cleanly. - Spatial Pattern interp paragraph now sits above the map (east-west gradient is the dominant signal, smaller south-north component). - Per-Ecoregion Variation gains a brief interp paragraph above the facets (uniform warming, precipitation diverges in the north, VPD up in all five). - Day-night asymmetry headline moved into the section's intro paragraph so the reader sees the conclusion before the figures. - Tightened acronym usage: "AOI" -> "area of interest", "BC" -> "British Columbia" in prose. Removed Arctic-draining clarification sentence and the dropped-cross-vignette KOTL reference. - Load-vignette-data chunk now visible so the reader sees how `ts` and downstream products materialize from the cache. - Removed the bottom "A note on reproducibility" section (cache is documented in chunk comments). - All six tables now have single, clean bookdown captions. Fixed the kableExtra+bookdown double-caption issue: pass `label = NA` and `caption = "..."` to the inner knitr::kable() — `tab.cap` chunk option silently drops captions when wrapped in scroll_box. Closes #47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Watershed Groups Across Ecoregions" section to the
peace-fwcpvignette and canonicalizes the FWCP Peace watershed-group list to 16. Lets readers connect per-ecoregion climate-departure findings to the watershed-group reporting unit (the unit FWCP funds work in, the unit our fish-passage reports use).Headline additions:
data-raw/example_context_fwcp_peace.Rfor reuse: CARP, CRKD, FINA, FINL, FIRE, FOXR, INGR, LOMI, MESI, NATR, OSPK, PARA, PARS, PCEA, TOOD, UOMI. Each is ≥99% inside the FWCP polygon. Drops UPCE (11.8% inside; main drainage runs east past FWCP) and MURR (1% sliver).Other improvements rolled in:
load-vignette-datachunk now visible — reader sees howtsand downstream products materialize from the cache.Caption fix worth calling out:
All six tables now render with single, clean bookdown captions. Fixed a kableExtra + bookdown double-caption issue: pass
label = NAalongsidecaption = "..."to the innerknitr::kable(). Thetab.capchunk option I tried earlier silently drops captions when the table is wrapped inkable_styling()+scroll_box(). Memory updated.Test plan
data-raw/example_context_fwcp_peace.Rruns end-to-end with the hardcoded 16-WSG list, regenerates the bundled gpkg with 16 WSGsdata-raw/peace_wsg_ecoregion_commentary.Rruns and produces the 16-row commentary CSVdevtools::build_rmd("vignettes/peace-fwcp.Rmd")renders cleanly in ~10 sNotes
This vignette is the template for our three reporting climate-departure appendices and ports directly to
fish_passage_peace_reporting_2025. The canonical 16-WSG list is the one to use in the shared GIS project setup going forward.Fixes #47
Relates to NewGraphEnvironment/sred-2025-2026#23
🤖 Generated with Claude Code