Replace raw SQL in network_extract.R with fresh::frs_network()#24
Merged
NewGraphEnvironment merged 2 commits intomainfrom Mar 10, 2026
Merged
Replace raw SQL in network_extract.R with fresh::frs_network()#24NewGraphEnvironment merged 2 commits intomainfrom
NewGraphEnvironment merged 2 commits intomainfrom
Conversation
fly is airphoto footprint estimation, diggs is BC Historic Airphoto Explorer — not downstream mapping/Shiny for drift/flooded. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Swap 50-line hand-written SQL + DBI connection for a single frs_network() call with upstream_measure (network subtraction). Regenerate bundled streams.gpkg — same 50 segments, one boundary segment shifted due to pure ltree vs old hybrid DRM+ltree approach. All 118 tests pass. Fixes #22 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-raw/network_extract.Rwith a singlefresh::frs_network()call usingupstream_measure(network subtraction)inst/testdata/streams.gpkg— same 50 segments, one boundary segment shifted due to pure ltree vs old hybrid DRM+ltree approachTest plan
devtools::test()— 118 passingRelates to NewGraphEnvironment/sred-2025-2026#5
🤖 Generated with Claude Code