Replace observations with barrier_overrides from link#130
Merged
NewGraphEnvironment merged 1 commit intomainfrom Apr 12, 2026
Merged
Replace observations with barrier_overrides from link#130NewGraphEnvironment merged 1 commit intomainfrom
NewGraphEnvironment merged 1 commit intomainfrom
Conversation
Fish passage interpretation (observation counting, date filters, species grouping, thresholds) belongs in link, not fresh. Replace the complex observations parameter with a simple barrier_overrides table of (blue_line_key, downstream_route_measure, species_code) prepared by link via lnk_barrier_overrides(). Fresh just skips matched barriers — no counting, no thresholds. - Replace .frs_access_with_observations() with .frs_access_with_overrides() - Remove observation_* columns from parameters_fresh.csv - barrier_overrides param on frs_habitat_classify() and frs_habitat() - Early return when no overrides exist for a species (skip recompute) Fixes #129 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the complex
observationsparameter (#69) with a simplebarrier_overridestable. Fish passage interpretation (observation counting, date filters, species grouping, thresholds) belongs in link, not the network engine.barrier_overridesparameter onfrs_habitat()andfrs_habitat_classify()— table of(blue_line_key, downstream_route_measure, species_code)prepared by link vialnk_barrier_overrides().frs_access_with_observations()and all observation counting SQLobservation_*columns fromparameters_fresh.csvTest plan
Fixes #129
Relates to NewGraphEnvironment/link#25
Relates to NewGraphEnvironment/sred-2025-2026#16