Auto-skip gradient/cw thresholds on lake/wetland rules#132
Merged
Conversation
When a rule has waterbody_type L or W, automatically set inherit_thresholds = FALSE for gradient and channel_width. Lake and wetland flow lines are routing lines through waterbodies — channel width is meaningless on them and gradient is near-zero. Rule-level explicit overrides (rule[["gradient"]] etc.) still apply if deliberately set. Only CSV inheritance is auto-skipped. Fixes SK rearing: 134 km (+thresholds) -> 230 km (-thresholds), matching bcfishpass v0.5.0 which only checks area_ha for lake rearing. 4 new tests + 1 existing test updated. 669 tests pass. Fixes #131 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waterbody_type: L(lake) orwaterbody_type: W(wetland). Lake/wetland flow lines are routing lines through waterbodies — channel width is meaningless and gradient is near-zero.thresholds: falseworkaround on every lake/wetland rule in the YAML.area_hafor lake rearing.Test plan
Fixes #131
Relates to NewGraphEnvironment/sred-2025-2026#16