Add wetland_rearing column to frs_habitat_classify output#164
Merged
NewGraphEnvironment merged 1 commit intomainfrom Apr 24, 2026
Merged
Add wetland_rearing column to frs_habitat_classify output#164NewGraphEnvironment merged 1 commit intomainfrom
NewGraphEnvironment merged 1 commit intomainfrom
Conversation
Mirrors the lake_rearing pattern, joined to fwa_wetlands_poly instead of fwa_lakes_poly. Lets callers distinguish wetland-based rearing habitat from lake-based rearing in per-segment boolean form — needed so downstream rollup layers can report lake_rearing_ha and wetland_rearing_ha as separate compound rollup columns. Per-species opt-in via rules YAML / dimensions.csv lands on top of this column. This is just the raw 'segment is a wetland under the species rear channel-width window' flag — any species whose rear channel_width range matches will get wetland_rearing evaluated the same way they get lake_rearing evaluated today. Prereq for link#51 (default config with compound rollup).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
wetland_rearingboolean column tofrs_habitat_classify()'s output schema, mirroring the existinglake_rearingpattern joined tofwa_wetlands_polyinstead offwa_lakes_poly. Prerequisite for link-side work that needs to distinguish wetland-based from lake-based rearing in compound rollups (see link#51).Changes
R/frs_habitat_classify.Rwetland_rearing booleanalongsidelake_rearing.wetland_rear_condmirroringlake_rear_cond— same per-species rear channel-width window, joined towhse_basemapping.fwa_wetlands_polyonwaterbody_key.wetland_rearingin the output schema; example SELECT extended.man/frs_habitat_classify.Rdregenerated.Per-species opt-in via rules YAML / dimensions.csv lands on top of this column in a follow-up — this PR is just the raw "segment is a wetland under the species' rear channel-width window" flag. Any species whose rear channel_width range matches today gets
wetland_rearingevaluated the same way they getlake_rearingevaluated today.Test plan
devtools::test(filter = "frs_habitat_classify")on M1 — 41 PASS, 0 FAIL.devtools::test()on M4 (full-suite rerun scheduled separately; dispatched but slow on M1, not blocking).No behaviour change for existing callers —
lake_rearingsemantics unchanged.wetland_rearingis a net-new column that defaults toFALSEfor any species whose rear channel_width range doesn't include wetland-classified segments.Bumps fresh to 0.16.0 (additive schema change).
Relates to link#51.