Replace httr with httr2 in spk_geoserv_dlv()#10
Merged
NewGraphEnvironment merged 1 commit intomainfrom Feb 7, 2026
Merged
Conversation
NewGraphEnvironment
pushed a commit
that referenced
this pull request
Feb 6, 2026
- Add @importFrom httr2 request req_url_query req_error req_perform resp_status - Add req_error(is_error = \(resp) FALSE) to prevent httr2 from auto-throwing on 4xx/5xx responses, allowing manual status check and error handling Addresses Claude code review feedback on PR #10. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Migrates from deprecated httr to actively maintained httr2: - httr::GET() -> httr2::request() |> req_url_query() |> req_perform() - httr::write_disk() -> req_perform(path = ...) - httr::status_code() -> httr2::resp_status() - cat() messages -> cli::cli_alert_success/cli_abort for consistency Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
04f4955 to
61a34c3
Compare
ReviewSummary: Clean migration from deprecated httr to httr2. Code changes are correct and follow best practices. Correctness: ✅
Error Handling: ✅
Consistency: ✅
Potential Issue: Recommendation: Approve and merge. All 44 tests reportedly passing per PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9
Migrates from deprecated
httrto actively maintainedhttr2:httr::GET()→httr2::request() |> req_url_query() |> req_perform()httr::write_disk()→req_perform(path = ...)httr::status_code()→httr2::resp_status()cat()messages →cli::cli_alert_success/cli_abortfor consistencyAll 44 tests passing.