Fix race conditions on unmount, and verify volume is actually attached to the correct node#7
Merged
shahedex merged 4 commits intoNexGenCloud:mainfrom Oct 3, 2025
Conversation
Contributor
|
Adding here, I don't think this was actually the issue we were running into. I believe the source of the issue is that the Hyperstack Volumes API returns the wrong device mount point. Specifically, the where the volume is actually mounted on the node after a |
shafinhasnat
approved these changes
Oct 3, 2025
| }, | ||
| }, nil | ||
| attachedInstanceIdStr := *(*getVolume.Attachments)[0].InstanceId | ||
| attachedInstanceId, err := strconv.Atoi(attachedInstanceIdStr) |
| } | ||
| if *v.Status == "in-use" && len(*v.Attachments) > 0 { | ||
| attachment := (*v.Attachments)[0] | ||
| attachedId, err := strconv.Atoi(*attachment.InstanceId) |
Contributor
There was a problem hiding this comment.
Int type set to strconv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, there isn't any polling on volume unpublished, or any verification that a disk is actually attached to the correct node in the volume publish. Adding both checks here to avoid mounting in another containers volume. Could be missing the mark here on root cause - this is a WIP as I test this on our staging cluster