Skip to content

hotfix: codeql workflow#393

Merged
Thyodas merged 2 commits intomainfrom
feat/fix-codeql
Jul 25, 2025
Merged

hotfix: codeql workflow#393
Thyodas merged 2 commits intomainfrom
feat/fix-codeql

Conversation

@Thyodas
Copy link
Copy Markdown
Member

@Thyodas Thyodas commented Jul 25, 2025

This pull request updates the CodeQL workflow configuration in .github/workflows/codeql.yml to enhance language support.

The workflow now builds the project manually instead of autobuild via CodeQL.
CodeQL can now scan C++ and C# code.

Summary by CodeRabbit

  • Chores
    • Updated CodeQL workflow to combine C/C++ and C# language entries and switch to manual build mode with Ninja generator.
    • Added a CMake packaging step with improved compiler environment configuration for build consistency.

@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 25, 2025

Walkthrough

The CodeQL workflow configuration was updated to merge "c-cpp" and "csharp" language entries into one with manual build mode, add a "generator" matrix field, and introduce a new step that runs a CMake workflow using specific presets and environment variables for compiler configuration.

Changes

File(s) Change Summary
.github/workflows/codeql.yml Updated workflow matrix to merge language entries, added "generator" field, and introduced a CMake build step with environment variable configuration for compiler selection.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested labels

enhancement

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/fix-codeql

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot added the enhancement New feature or request label Jul 25, 2025
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 634fea5 and daadbf6.

📒 Files selected for processing (1)
  • .github/workflows/codeql.yml (2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: Thyodas
PR: NexoEngine/game-engine#352
File: engine/src/scripting/native/NativeApi.cpp:92-97
Timestamp: 2025-07-22T15:08:24.224Z
Learning: The NexoEngine project uses a specific GitHub issue template for tasks with the following structure: YAML format with fields for objective (required), acceptance criteria (required), dependencies, technical details (with Environment/Components/Resources subfields), and type dropdown (Engine/Editor/CI/CD/Testing/Documentation/Bug/Feature/Other). The template is referenced as "Task template" and includes project association "NexoEngine/3". Title format should follow "[feat | refactor | chore | bug]: description" pattern.
Learnt from: Thyodas
PR: NexoEngine/game-engine#352
File: engine/src/scripting/native/NativeApi.cpp:92-97
Timestamp: 2025-07-22T15:08:24.224Z
Learning: The NexoEngine project uses a specific GitHub issue template for tasks with the following structure: YAML format with fields for objective (required), acceptance criteria (required), dependencies, technical details (with Environment/Components/Resources subfields), and type dropdown (Engine/Editor/CI/CD/Testing/Documentation/Bug/Feature/Other). The template is referenced as "Task template" and includes project association "NexoEngine/3". Title format should follow "[feat | refactor | chore | bug]: description" pattern.
🪛 actionlint (1.7.7)
.github/workflows/codeql.yml

137-137: property "set-up-clang" is not defined in object type {set-up-gcc: {conclusion: string; outcome: string; outputs: {string => string}}}

(expression)


138-138: property "set-up-clang" is not defined in object type {set-up-gcc: {conclusion: string; outcome: string; outputs: {string => string}}}

(expression)


139-139: property "set-up-clang" is not defined in object type {set-up-gcc: {conclusion: string; outcome: string; outputs: {string => string}}}

(expression)


140-140: property "set-up-clang" is not defined in object type {set-up-gcc: {conclusion: string; outcome: string; outputs: {string => string}}}

(expression)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Build, test and Package (windows-latest, msvc)
  • GitHub Check: Build, test and Package (ubuntu-latest, gcc)
  • GitHub Check: Analyze (c-cpp, csharp/gcc) on ubuntu-latest
🔇 Additional comments (1)
.github/workflows/codeql.yml (1)

130-135: Verify that the ‘minimal-build’ CMake preset actually performs a build

build-mode: manual requires CodeQL to observe compilation commands.
If the preset only configures but does not compile, the scan will generate an empty database.

Please confirm that minimal-build includes the build phase or switch to configurePreset + buildPreset in lukka/run-cmake.

Comment thread .github/workflows/codeql.yml
Comment thread .github/workflows/codeql.yml
@Thyodas Thyodas merged commit f79d4e6 into main Jul 25, 2025
5 of 6 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Global timeline Jul 25, 2025
@Thyodas Thyodas deleted the feat/fix-codeql branch July 25, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants