Compare
Sorry, something went wrong.
No results found
fix: address all Obsidian plugin review errors and warnings
Errors:
- Replace createEl(h2/h3) with new Setting().setHeading() (4 places)
- Add descriptions to eslint-disable comments in native-manager.ts
Warnings:
- Replace builtin-modules pkg with Node.js built-in module.builtinModules
- Add eslint-disable with explanation for fetch(app://) in fileToArrayBuffer
- Fix new Array → new Array<T> to avoid unsafe-assignment
- Replace setWarning() with setDestructive() (3 places)
- Change onConfirm type to () => void | Promise<void>; void the call
- Fix command id: remove plugin-id prefix → 'ocr-current-note'
- Fix command name: remove plugin name prefix → 'OCR Current Note'
- Fix onunload: remove async, use void .catch() pattern
- Fix loadSettings: cast loadData() result to Partial<OcrImageSettings>
Recommendations:
- Remove unused arrayBufferToBase64 function
- Replace deprecated Buffer.slice() with Buffer.subarray() (5 places)